Opened 10 years ago
Closed 10 years ago
#582 closed enhancement (fixed)
Change 'LymfnodeRegional' to 'LymphnodeRegional' for 'SpecimenType' annotation
Reported by: | Nicklas Nordborg | Owned by: | olle |
---|---|---|---|
Priority: | minor | Milestone: | Reggie v2.15 |
Component: | net.sf.basedb.reggie | Keywords: | |
Cc: |
Description
Need to change the installation wizard and the specimen tube registration wizard with the new option.
Existing specimen items with the old value should be changed manually or with the batch annotation importer.
Change History (5)
comment:1 Changed 10 years ago by
Owner: | changed from Nicklas Nordborg to olle |
---|---|
Status: | new → assigned |
comment:2 Changed 10 years ago by
Problem discussion:
A text search revealed that text string "LymfnodeRegional
" appeared in java servlet file InstallServlet.java
in reggie/src/net/sf/basedb/reggie/servlet/
and JSP script specimentube.jsp
in reggie/resources/sampleproc/
:
- Java servlet file
InstallServlet.java
inreggie/src/net/sf/basedb/reggie/servlet/
checksAnnotationtype.SPECIMEN_TYPE
for value optionLymfnodeRegional
in protected methodvoid doGet(HttpServletRequest req, HttpServletResponse resp)
. - JSP script
specimentube.jsp
inreggie/resources/sampleproc/
adds optionLymfnodeRegional
for specimen type in HTML section.
comment:3 Changed 10 years ago by
(In [2251]) Refs #582. Specimen type annotation LymfnodeRegional
for specimen tube updated to LymphnodeRegional
:
- JSP script
specimentube.jsp
inreggie/resources/sampleproc/
updated in HTML section to add optionLymphnodeRegional
for specimen type, instead ofLymfnodeRegional
. - Java servlet class/file
InstallServlet.java
inreggie/src/net/sf/basedb/reggie/servlet/
updated in protected methodvoid doGet(HttpServletRequest req, HttpServletResponse resp)
to checkAnnotationtype.SPECIMEN_TYPE
for value optionLymphnodeRegional
, instead ofLymfnodeRegional
.
comment:4 Changed 10 years ago by
Comments:
- The updated code adds value option
LymphnodeRegional
to the enumeration forAnnotationtype.SPECIMEN_TYPE
, but the existing optionLymfnodeRegional
remains, and has to be removed manually. - The description for
Annotationtype.SPECIMEN_TYPE
is "Specifies the specimen type as determined by pathology/surgery, e.g., primary, lymfnode, recurrence.
", i.e. it refers to "lymfnode
", instead of "lymphnode
", and also has to be changed manually.
comment:5 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Ticket closed as the requested changes have been added.
Ticket accepted.