Opened 10 years ago
Closed 10 years ago
#509 closed defect (fixed)
Error icons after successful registration of caliper lib results
Reported by: | Nicklas Nordborg | Owned by: | olle |
---|---|---|---|
Priority: | minor | Milestone: | Reggie v2.13 |
Component: | net.sf.basedb.reggie | Keywords: | |
Cc: |
Description
The Library registration wizard display error icons for all messages. Even after successful registration.
Change History (5)
comment:1 Changed 10 years ago by
Owner: | changed from Nicklas Nordborg to olle |
---|
comment:2 Changed 10 years ago by
Status: | new → assigned |
---|
comment:3 Changed 10 years ago by
Problem discussion:
- Library registration is managed by JSP script
lib_registration.jsp
inreggie/resources/libprep/
and Java servletLibPrepServlet.java
inreggie/src/net/sf/basedb/reggie/servlet/
. - General messages are displayed with an HTML
div
tag in the JSP script withid="messages"
. The icon displayed for the message is controlled by the class of thediv
tag, which initially is set toclass="success"
, but can be changed in the JSP script with theMain.addClass(...)
function, where commandMain.addClass(document.getElementById('messages'), 'failure')
results in an error icon being displayed. - Nicklas Nordborg discovered that when the class of element
messages
was set to'failure'
in order to display an error icon, the class was never reset after the error had been fixed. This led to an error icon being displayed also for success messages.
Proposed solution:
- JSP script
lib_registration.jsp
inreggie/resources/libprep/
is updated in functionsonWellTableValidated(request)
andgoRegister()
to callMain.removeClass(document.getElementById('messages'), 'failure')
to remove any error indication after data has passed validation.
comment:4 Changed 10 years ago by
comment:5 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Ticket closed after successful passing of local test.
Note: See
TracTickets for help on using
tickets.
Ticket accepted.