Opened 5 years ago
Closed 5 years ago
#1178 closed enhancement (fixed)
Scripts should not fail if it can't change group on files
Reported by: | Nicklas Nordborg | Owned by: | Nicklas Nordborg |
---|---|---|---|
Priority: | major | Milestone: | Reggie v4.23.1 |
Component: | net.sf.basedb.reggie | Keywords: | |
Cc: |
Description (last modified by )
See #1174. This implemented a 'chgrp' command to allow external data to be shared to a specific group based on the prefix used on the sample names. However, if the 'chgrp' command fails (for example if the specified group doesn't exists or is inaccessible for the current user), the entire script fails and results will not be imported back into BASE.
Error: [1] chgrp: changing group of `/home/thep-nni/../.._L1_R1.fastq.gz': Operation not permitted ...
This is a bit unfortunate since the failure can typically be fixed easily by a superuser on the file server and there is really no need to have to delete and re-run the analysis.
Change History (6)
comment:1 by , 5 years ago
Description: | modified (diff) |
---|
comment:2 by , 5 years ago
comment:5 by , 5 years ago
Milestone: | Reggie v4.24 → Reggie v4.23.1 |
---|
comment:6 by , 5 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Since there is no good way to report back warnings from the other steps in the secondsary analysis I think the best options for now is to simply ignore it. Most problems should be catched in the demux step in any case.
If we do
chgrp .... || true
a failure to change the group will not stop the script. Error messages will be written tostderr
. We could redirect to a file:chgrp ... 2>> ${WD}/chgrp.out || true
. Then it would be possible for Reggie to pick up any problems and maybe issue a warning (${WD}
is the working directory for the job that we already use for other data files that we need information from after the job has been completed).