Opened 4 years ago

Closed 4 years ago

#912 closed defect (fixed)

Fix report delivery system

Reported by: Nicklas Nordborg Owned by: Nicklas Nordborg
Priority: critical Milestone: Reggie v4.7.1
Component: net.sf.basedb.reggie Keywords:
Cc:

Description (last modified by Nicklas Nordborg)

This seems to not work properly. The only use case that seems to get properly registered and shared to the correct site is when all of the following are fulfilled:

  • Only a single specimen tube is registered
  • The YellowLabel annotation is NOT SET in the "Specimen tube registration" wizard
  • The YellowLabel annotation is SET in the "Referral form registration" wizard.

More investigations are needed since there may be other unknown problems (there seems to be a properly shared case that is not showing up in the delivery client).

It would also be nice if the final "Publish for delivery" functionality could check (and fix) everything. This will currently only make sure that the PDF file is correctly shared which doesn't help in case the other information is incorrect.

Change History (8)

comment:1 Changed 4 years ago by Nicklas Nordborg

Description: modified (diff)

comment:2 Changed 4 years ago by Nicklas Nordborg

Milestone: Reggie v4.8Reggie v4.7.1

comment:3 Changed 4 years ago by Nicklas Nordborg

I have made some investigations when it comes to registering new specimen tubes and patients.

  • If the YellowLabel is set by the "Specimen tube registration" wizard the specimen/case/patient will not be shared to the site.
  • The workaround is to reset all YellowLabel specimen in the "Pathology referral form" wizard. Save. Run the wizard a second time and set the YellowLabel checkbox. But this will only work for at most one specimen tube.
  • This seems to share the items to the site correctly but it doesn't show up in the delivery wizard when the "senaste 30 dagarna" option is used. Using the search functionality with the SCAN-B ID brings it up under "Arbete pågår" section.

comment:4 Changed 4 years ago by Nicklas Nordborg

The reason that specimen are not showing up in the "senaste 30 dagarna" is that the calculation for the start date uses the calculates the number of milliseconds in 30 days using 30*24*3600*1000 which yields the result: -1702967296!!

This is due to an Java using an integer data type instead of long which causes a silent overflow to a negative number. Switching to a long data type seems to fix the problem.

comment:5 Changed 4 years ago by Nicklas Nordborg

(In [4134]) References #912: Fix report delivery system

Fixes the problem with a future start date being generated for the "last 30 days" filter. The calculation now uses a long data type and should not overflow.

comment:6 Changed 4 years ago by Nicklas Nordborg

(In [4135]) References #912: Fix report delivery system

Re-designed they way items are published to sites. Most logic has been moved to the SetPermissionsForDeliverPlugin class. The calling code only need to provide a list with items and the plug-in will check which permissions they should or should not have.

This change fixes the problems with the "Pathology referral form registration" wizard. Publishing the PDF reports do not work at all yet.

comment:7 Changed 4 years ago by Nicklas Nordborg

(In [4136]) References #912: Fix report delivery system

Changes the "Publish for delivery" function to only send the PDF files to the SetPermissionsForDeliveryPlugin. The plug-in will make sure that the file and parent directories are shared to the correct site and to the patient curator group.

Using the "Mark as completed" function in the "Yellow label tracking" wizard will now also check and fix the site sharing if needed.

comment:8 Changed 4 years ago by Nicklas Nordborg

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.