Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#789 closed defect (fixed)

LabEnv links in Case Summary do not work with BASE 3.5

Reported by: olle Owned by: olle
Priority: major Milestone: LabEnv v1.4
Component: net.sf.basedb.labenv Keywords:
Cc:

Description

Clicking on a LabEnv link for an item in the Case Summary opens up a pop-up window with an error message in BASE 3.5, instead of the expected temperature and humidity graphs for the date in question.

Change History (8)

comment:1 Changed 6 years ago by olle

Status: newassigned

Ticket accepted.

comment:2 Changed 6 years ago by olle

Traceability note:

  • The lab environment extension was introduced in Ticket #529 (Retrieve and store temperature and humidity measurements).
  • Reggie ticket #530 (Display logs from temperature and humidity measurements) is concerned with retrieving data from the lab environment data base for specific dates of interest for the sample preparation and sequencing.

LabEnv v1.1:

  • The lab environment extension was updated in Ticket #592 (Lab environment extension improved report routines).

LabEnv v1.2:

  • The lab environment extension was updated in Ticket #607 (Date /time format is different in configuration file and GUI).
  • The lab environment extension was updated in Ticket #610 (Mail server prints debug output as default).
  • The lab environment extension was updated in Ticket #612 (LabEnv overview display shows wrong time offsets when the latest data points are filtered away).
  • The lab environment extension was updated in Ticket #615 (Lab environment extension stability improvement and bug fixes for v1.1).

LabEnv v1.3:

  • The lab environment extension was updated in Ticket #606 (Switch to JDOM 2).
  • The lab environment extension was updated in Ticket #608 (Update !Labenv to new scripting pattern).
  • The lab environment extension was updated in Ticket #706 (Update LabEnv to use BASE database capabilities instead of SQLite).
  • The lab environment extension was updated in Ticket #714 (Get rid of warning messages from HttpMethodBase).
  • The lab environment extension was updated in Ticket #715 (Do not query the sensor for it's name every time).

comment:3 Changed 6 years ago by olle

Problem analysis:

  • The error message pinpoints a statement in javascript file labenvironmentdatabaseeventpopup.js in resources/reports/ that calls the BASE javascript routine Main.show(...). Javascript library Main was deprecated in BASE 3.4 and removed in BASE 3.5, so that and two other calls to functions in Main should be updated.

comment:4 Changed 6 years ago by olle

(In [3364]) Refs #789. Calls of functions in removed BASE javascript library Main updated:

  1. Javascript file labenvironmentdatabaseeventpopup.js in resources/reports/ updated:
    a. Function onPlotGenerated(response) updated by exchanging call Main.show('reportSection')for Doc.show('reportSection').
    b. Function drawCanvasGuidelines(event) updated by exchanging call Main.getElementPosition(canvas) for Doc.getElementPosition(canvas) and Main.getWindowHeight() for App.getWindowPosition().height.

comment:5 Changed 6 years ago by olle

Test:

  • The updated code was tested on a locally installed system, where Case Summary was inspected for a case, with extraction dates for RNA, DNA, and FlowThrough in a range where lab environment data had been collected in the local database. When a LabEnv icon was clicked, a pop-up window appeared with graphs of temperature and humidity in the extraction lab for the date in question. This is the desired behavior, and the test therefore passed with successful result.

comment:6 Changed 6 years ago by olle

Resolution: fixed
Status: assignedclosed

The ticket is closed since the added update fixes the problem on the test system.

comment:7 Changed 6 years ago by olle

Summary: LabEnv links in Case Summary does not work with BASE 3.5LabEnv links in Case Summary do not work with BASE 3.5

Grammar fixed in ticket summary.

comment:8 Changed 6 years ago by Nicklas Nordborg

Milestone: LabEnv v1.xLabEnv v1.4
Note: See TracTickets for help on using tickets.