Opened 7 years ago

Closed 7 years ago

#430 closed enhancement (fixed)

Consent count report should allow time period selection

Reported by: olle Owned by: olle
Priority: major Milestone: Reggie v2.9
Component: net.sf.basedb.reggie Keywords:
Cc:

Description

Consent count report should allow time period selection, similar to the sample count report.

  • Time period should be selected by giving start and end dates. The same defaults as for the sample count report should be used, i.e. the project start date for start date, and current date for end date.
  • The "Sum" column should display the number of consents with dates in the selected time period, plus the number of consents without dates (the latter should include missing consents).
  • A new "Total" column should be added to the right of the "Sum" column, and show the sum of consents regardless of date, plus the number of consents without dates.
  • The current consent count table should be split in two: one table with consents with dates in the selected time period, plus a column for items, where the date is unknown:

    1. Yes (has PAT#)
    2. Yes (no PAT#)
    3. No (has date)
    4. Not asked (has date)
    5. Unknown date (should include missing consents)
    6. Sum
    7. Total

    and one special table for items, with unknown dates:

    1. Yes (no date)
    2. No (no date)
    3. Not asked (no date)
    4. Missing
    5. Sum
    6. Total

Change History (4)

comment:1 Changed 7 years ago by olle

Status: newassigned

Ticket accepted.

comment:2 Changed 7 years ago by olle

Traceability note:

  • The consent count report was introduced in Ticket #426 (Consent count report generator).
  • It was updated in Ticket #428 (Reports should have sites in alphabetic order and a column with latest item dates).

comment:3 Changed 7 years ago by olle

Design discussion:

  • Unlike the sample count report, the consent count report will at present not display data in smaller time units for the selected time period (e.g. by year, quarter, month, week), so there is no need for a "View type" input. Even so, the similarities in input between the sample count and consent count report are now so great, as to warrant use of the same HTML code base. In order for this to be possible, the code in JSP script samplereportgenerator.jsp in reggie/resources/ should be refactored, and elements not present in all cases, should be placed inside <div id="..."></div> tags, that can be used to hide and show the element as needed. Similarly, portions of text that should be replaced, should be placed inside <text id="...">items</text> tags.
  • JSP script samplereportgenerator.jsp in reggie/resources/ should be updated to show the new consent table data, and insert a new table for items with unknown date. In order to simplify the latter, a new convenience function addDataRowsToConsentTableUnknownDate(report, reportTable, numDecimals) should be added.
  • Servlet class/file SampleReportServlet in reggie/src/net/sf/basedb/reggie/servlet/ should be updated in private method JSONObject createConsentCountReport(...) to take start and end date as new arguments, and only update site counters if a consent with date lies in the selected time period.
Last edited 7 years ago by olle (previous) (diff)

comment:4 Changed 7 years ago by olle

Resolution: fixed
Status: assignedclosed

(In [1738]) Fixes #430. Refs #426. Consent count report updated to allow a time period to be selected. Results are now shown in two tables, one for consents with dates in the selected time period (plus a column for items, where the date is unknown), and one special table for items with unknown dates.

Note: See TracTickets for help on using tickets.