Changes between Initial Version and Version 1 of Ticket #525, comment 64


Ignore:
Timestamp:
May 4, 2016, 2:36:10 PM (9 years ago)
Author:
olle

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #525, comment 64

    initial v1  
    11Design discussion:
    22
    3  * The functionality added in change set [http://baseplugins.thep.lu.se/changeset/3840 [3840]] 2016-04-13, where the INCA importer was updated to allow the program to handle internal line feed and tab characters, provided the *.csv file is saved with "Text delimiter" set to a double quote character '"', instead of an empty string (blank), was kept in the code when the latter was adapted in change set [http://baseplugins.thep.lu.se/changeset/3889 [3889]] etc. 2016-04-28 to be used with a single INCA input file obtained by feeding a special program with a raw INCA XML file and a SCAN-B *.csv request file. The idea was to have an INCA importer that could be used with both kind of files, as replacing tabs with spaces inside sections within double quotes should not change anything, if internal tabs had already been replaced by "`\t`" by the special conversion program.[[BR]]][[BR]]Unfortunately, inspection of new INCA files has shown the (pretty non-standard) custom of prefixing an entry value in a comment with a single double quote '`"`', leading to all tabs separating columns being replaced by spaces until the next double quote is found, resulting in chaos when lines are concatenated to obtain the number of columns in the header line. As this custom would not have worked with the original *.csv file creation procedure, unless original double quotes were escaped, the functionality added in change set [http://baseplugins.thep.lu.se/changeset/3840 [3840]] will be removed, as new INCA import files will be created using the special program at INCA.
     3 * The functionality added in change set [http://baseplugins.thep.lu.se/changeset/3840 [3840]] 2016-04-13, where the INCA importer was updated to allow the program to handle internal line feed and tab characters, provided the *.csv file is saved with "Text delimiter" set to a double quote character '"', instead of an empty string (blank), was kept in the code when the latter was adapted in change set [http://baseplugins.thep.lu.se/changeset/3889 [3889]] etc. 2016-04-28 to be used with a single INCA input file obtained by feeding a special program with a raw INCA XML file and a SCAN-B *.csv request file. The idea was to have an INCA importer that could be used with both kind of files, as replacing tabs with spaces inside sections within double quotes should not change anything, if internal tabs had already been replaced by "`\t`" by the special conversion program.[[BR]][[BR]]Unfortunately, inspection of new INCA files has shown the (pretty non-standard) custom of prefixing an entry value in a comment with a single double quote '`"`', leading to all tabs separating columns being replaced by spaces until the next double quote is found, resulting in chaos when lines are concatenated to obtain the number of columns in the header line. As this custom would not have worked with the original *.csv file creation procedure, unless original double quotes were escaped, the functionality added in change set [http://baseplugins.thep.lu.se/changeset/3840 [3840]] will be removed, as new INCA import files will be created using the special program at INCA.
    44
    55Design update: