Opened 4 years ago

Closed 4 years ago

#890 closed enhancement (fixed)

Remove calls to methods deprecated in BASE 3.9

Reported by: Nicklas Nordborg Owned by: Nicklas Nordborg
Priority: major Milestone: Reggie v4.5
Component: net.sf.basedb.reggie Keywords:
Cc:

Description (last modified by Nicklas Nordborg)

See http://base.thep.lu.se/ticket/2011

Reggie is full of calls to the deprecated 2-argument version of Application.getSessionControl(). I think we should:

  • Re-factor the code so that the call is made in via a utility function.
  • Use a separate client id for Reggie.
  • Call the 4-argument version of Application.getSessionControl() which also checks that a user is logged in. This is currently not done and may in some cases result in an exception later on and in some cases result in an empty data structure being returned. Better to throw a NotLoggedInException immediately.

Change History (7)

comment:1 Changed 4 years ago by Nicklas Nordborg

Description: modified (diff)

comment:2 Changed 4 years ago by Nicklas Nordborg

(In [3973]) References #890: Remove calls to methods deprecated in BASE 3.9

Added utility method for getting a session control.

comment:3 Changed 4 years ago by Nicklas Nordborg

(In [3974]) References #890: Remove calls to methods deprecated in BASE 3.9

Installation wizard create "Reggie" client application.

comment:4 Changed 4 years ago by Nicklas Nordborg

(In [3975]) References #890: Remove calls to methods deprecated in BASE 3.9

Changed all code for getting a session control in the servlets to use the new utility method in class Reggie.

comment:5 Changed 4 years ago by Nicklas Nordborg

(In [3976]) References #890: Remove calls to methods deprecated in BASE 3.9

Changed all code for getting a session control in the JSP files to specify the client id.

comment:6 Changed 4 years ago by Nicklas Nordborg

(In [3977]) References #890: Remove calls to methods deprecated in BASE 3.9

All extension points leading into Reggie now check if the logged in user is allowed to access Reggie before adding actions.

comment:7 Changed 4 years ago by Nicklas Nordborg

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.