Opened 5 years ago

Closed 5 years ago

#775 closed defect (fixed)

Histology scoring wizard does not work

Reported by: Nicklas Nordborg Owned by: Nicklas Nordborg
Priority: critical Milestone: Reggie v3.3.1
Component: net.sf.basedb.reggie Keywords:
Cc:

Description (last modified by Nicklas Nordborg)

It is not possible to register scores in the Histology wizard. To begin with everything seems to be ok, and the first sample on a glass can be scored without problems.

Clicking on the next sample doesn't move the selection to it. The original sample is still the one with the bluish background color. The name in the scoring table below the slides is updated to the sample that was clicked and the scoring information is cleared. However, entering the scores for the second sample will overwrite the scores on the first sample.

Checking the developer console in Firefix an error message appears every time a new sample is clicked:

InvalidCharacterError: String contains an invalid character

Seems like the change to a new sample is not working correctly. Some information like the name and score fields are update/cleared, then the error happens and the rest of the code that should update the selection is never executed.

Change History (5)

comment:1 Changed 5 years ago by Nicklas Nordborg

Milestone: Reggie v3.xReggie v3.3.1

comment:2 Changed 5 years ago by Nicklas Nordborg

Description: modified (diff)

comment:3 Changed 5 years ago by Nicklas Nordborg

Status: newassigned

comment:4 Changed 5 years ago by Nicklas Nordborg

The problem was an extra space in the class name when calling Doc.removeClass(..., ' selected');. This used to work, but in BASE 3.5 the class manipulation switched from using string search and replace to using the ClassList API instead (see http://base.thep.lu.se/ticket/1920). Space is not valid in class names. This didn't matter when doing string manipulation but now it does. It seems like this is the only place in Reggie where the extra space is present.

comment:5 Changed 5 years ago by Nicklas Nordborg

Resolution: fixed
Status: assignedclosed

(In [3278]) Fixes #775: Histology scoring wizard does not work

Removed the exta space.

Note: See TracTickets for help on using tickets.