Opened 7 years ago

Closed 7 years ago

#582 closed enhancement (fixed)

Change 'LymfnodeRegional' to 'LymphnodeRegional' for 'SpecimenType' annotation

Reported by: Nicklas Nordborg Owned by: olle
Priority: minor Milestone: Reggie v2.15
Component: net.sf.basedb.reggie Keywords:
Cc:

Description

Need to change the installation wizard and the specimen tube registration wizard with the new option.

Existing specimen items with the old value should be changed manually or with the batch annotation importer.

Change History (5)

comment:1 Changed 7 years ago by olle

Owner: changed from Nicklas Nordborg to olle
Status: newassigned

Ticket accepted.

comment:2 Changed 7 years ago by olle

Problem discussion:

A text search revealed that text string "LymfnodeRegional" appeared in java servlet file InstallServlet.java in reggie/src/net/sf/basedb/reggie/servlet/ and JSP script specimentube.jsp in reggie/resources/sampleproc/:

  1. Java servlet file InstallServlet.java in reggie/src/net/sf/basedb/reggie/servlet/ checks Annotationtype.SPECIMEN_TYPE for value option LymfnodeRegional in protected method void doGet(HttpServletRequest req, HttpServletResponse resp).
  2. JSP script specimentube.jsp in reggie/resources/sampleproc/ adds option LymfnodeRegional for specimen type in HTML section.

comment:3 Changed 7 years ago by olle

(In [2251]) Refs #582. Specimen type annotation LymfnodeRegional for specimen tube updated to LymphnodeRegional:

  1. JSP script specimentube.jsp in reggie/resources/sampleproc/ updated in HTML section to add option LymphnodeRegional for specimen type, instead of LymfnodeRegional.
  2. Java servlet class/file InstallServlet.java in reggie/src/net/sf/basedb/reggie/servlet/ updated in protected method void doGet(HttpServletRequest req, HttpServletResponse resp) to check Annotationtype.SPECIMEN_TYPE for value option LymphnodeRegional, instead of LymfnodeRegional.

comment:4 Changed 7 years ago by olle

Comments:

  1. The updated code adds value option LymphnodeRegional to the enumeration for Annotationtype.SPECIMEN_TYPE, but the existing option LymfnodeRegional remains, and has to be removed manually.
  2. The description for Annotationtype.SPECIMEN_TYPE is "Specifies the specimen type as determined by pathology/surgery, e.g., primary, lymfnode, recurrence.", i.e. it refers to "lymfnode", instead of "lymphnode", and also has to be changed manually.

comment:5 Changed 7 years ago by olle

Resolution: fixed
Status: assignedclosed

Ticket closed as the requested changes have been added.

Note: See TracTickets for help on using tickets.