Opened 6 years ago

Closed 6 years ago

#509 closed defect (fixed)

Error icons after successful registration of caliper lib results

Reported by: Nicklas Nordborg Owned by: olle
Priority: minor Milestone: Reggie v2.13
Component: net.sf.basedb.reggie Keywords:
Cc:

Description

The Library registration wizard display error icons for all messages. Even after successful registration.

Change History (5)

comment:1 Changed 6 years ago by olle

Owner: changed from Nicklas Nordborg to olle

comment:2 Changed 6 years ago by olle

Status: newassigned

Ticket accepted.

comment:3 Changed 6 years ago by olle

Problem discussion:

  • Library registration is managed by JSP script lib_registration.jsp in reggie/resources/libprep/ and Java servlet LibPrepServlet.java in reggie/src/net/sf/basedb/reggie/servlet/.
  • General messages are displayed with an HTML div tag in the JSP script with id="messages". The icon displayed for the message is controlled by the class of the div tag, which initially is set to class="success", but can be changed in the JSP script with the Main.addClass(...) function, where command Main.addClass(document.getElementById('messages'), 'failure') results in an error icon being displayed.
  • Nicklas Nordborg discovered that when the class of element messages was set to 'failure' in order to display an error icon, the class was never reset after the error had been fixed. This led to an error icon being displayed also for success messages.

Proposed solution:

  • JSP script lib_registration.jsp in reggie/resources/libprep/ is updated in functions onWellTableValidated(request) and goRegister() to call Main.removeClass(document.getElementById('messages'), 'failure') to remove any error indication after data has passed validation.

comment:4 Changed 6 years ago by olle

(In [2039]) Refs #509. JSP script lib_registration.jsp in reggie/resources/libprep/ is updated in functions onWellTableValidated(request) and goRegister() to call Main.removeClass(document.getElementById('messages'), 'failure') to remove any error indication after data has passed validation.

comment:5 Changed 6 years ago by olle

Resolution: fixed
Status: assignedclosed

Ticket closed after successful passing of local test.

Note: See TracTickets for help on using tickets.