Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#452 closed enhancement (fixed)

Consent count report should not count missing constents as consents with unknown date

Reported by: olle Owned by: olle
Priority: major Milestone: Reggie v2.10.1
Component: net.sf.basedb.reggie Keywords:
Cc:

Description (last modified by olle)

Consent count report should not count missing consents as consents with unknown date.

  1. The "Unknown date" column in the first table in the consent count report should only include items coupled to an actual consent form.
  2. The second table should still include a column with missing consents, but the table title should be clarified to read "# Consent forms of different types for cases and blood samples with unknown consent date, as well as items with missing consents".
  3. The "Total" column should never include missing consents.
  4. The percentage values in the second table for consents with unknown date and missing consents should now be based on the values in the "Sum" column of that table, i.e. the percentage values in table two should add to 100% in each row (allowing for rounding errors). Originally, the idea was that the percentage values in each row in table two should add to the percentage value for the same row in column "Unknown date" in table one, but since missing consents now are excluded from the latter column, this design is no longer useful.
  5. The number of missing consents for all sites should be shown in the comments section under the second table, with a note that these items are not included in the "Total" column.

Change History (8)

comment:1 Changed 7 years ago by olle

Status: newassigned

Ticket accepted.

comment:2 Changed 7 years ago by olle

Traceability note:

  • The consent count report was introduced in Ticket #426 (Consent count report generator).
  • It was updated in Ticket #428 (Reports should have sites in alphabetic order and a column with latest item dates).
  • The consent count report was updated in Ticket #430 (Consent count report should allow time period selection).

comment:3 Changed 7 years ago by olle

Description: modified (diff)

Updated ticket description concerning "Total" column and put changes in list form.

comment:4 Changed 7 years ago by olle

Description: modified (diff)

Updated ticket description by fixing typo.

comment:5 Changed 7 years ago by olle

Description: modified (diff)

Updated ticket description regarding calculation of percentage values in table two.

comment:6 Changed 7 years ago by olle

Design update:

  • A new JSON key value "noDateOrMissing" is introduced, in order to keep track of the new values.
  • JSP script samplereportgenerator.jsp in reggie/resources/ should be updated to calculate percentage values in the second table based on the "Sum" column in that table. The "Sum" column in table two will now take its values based on the new JSON key "noDateOrMissing". New comments will also be added.
  • Servlet class/file SampleReportServlet in reggie/src/net/sf/basedb/reggie/servlet/ should be updated to not include missing consents in the "noDate" column, nor in the columns for "Sum" and "Total". The new JSON value "noDateOrMissing" is used for consents with unknown date or missing consents. The number of missing consents is now made available via a separate JSON key in the "statistics" data, sent back to the servlet.
Last edited 7 years ago by olle (previous) (diff)

comment:7 Changed 7 years ago by olle

Resolution: fixed
Status: assignedclosed

(In [1784]) Fixes #452. Consent count report updated to not count missing consents as consents with unknown date.

comment:8 Changed 7 years ago by Nicklas Nordborg

Milestone: Reggie v2.10.1
Note: See TracTickets for help on using tickets.