Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#1254 closed defect (fixed)

Incorrect time in the follow-up blood batch importer

Reported by: Nicklas Nordborg Owned by: Nicklas Nordborg
Priority: critical Milestone: Reggie v4.27.3
Component: net.sf.basedb.reggie Keywords:
Cc:

Description

The follow-up blood batch importer (#1234) seems to be importing time values in the afternoon incorrectly. For example, 13:30 is imported as 1:30. 12 hours is missing.

Change History (2)

comment:1 by Nicklas Nordborg, 4 years ago

Resolution: → fixed
Status: new → closed

In 5967:

Fixes #1254: Incorrect time in the follow-up blood batch importer

There was a bug in the code that merged the 'date' and 'time' columns. The time part was set with the Calendar.HOUR field. The documentation for this field state that it should be a value between 0 and 11. To use 24-hour values the Calendar.HOUR_OF_DAY field must be used.

comment:2 by Nicklas Nordborg, 4 years ago

In 5969:

References #1254: Incorrect time in the follow-up blood batch importer

The time formatter in the importer was using 'hh' (12-hour format) instead of 'HH' (24-hour format). It should not affect importing, but may casuse incorrect display in error/warning messages.

Note: See TracTickets for help on using tickets.