Opened 12 months ago

Closed 12 months ago

Last modified 12 months ago

#1181 closed defect (fixed)

Incorrect counter for pilot reports in the activity log

Reported by: Nicklas Nordborg Owned by: Nicklas Nordborg
Priority: major Milestone: Reggie v4.23.1
Component: net.sf.basedb.reggie Keywords:
Cc:

Description

Created 16777214 pilot reports

This is clearly not correct. The entry before it:

Legacy pipeline auto-confirmed for 23 libraries

So the correct number of pilot reports should be 23.

Change History (4)

comment:1 Changed 12 months ago by Nicklas Nordborg

Trying this out by creating pilot reports one by one reveals that the counter is increasing as: 2, 6, 14, 30, 62, ... which seems to have a pattern of next=(current+1)*2. Or we can find out the value for N pilot reports by 2^(N+1) - 2). With N=23 we get 16777214.

comment:2 Changed 12 months ago by Nicklas Nordborg

Resolution: fixed
Status: newclosed

In 5614:

Fixes #1181: Incorrect counter for pilot reports in the activity log

There was a problem with the "merge" action that update entries in the activity log was added twice by the report plug-in. The first entry worked as expected by adding 1 to the existing count, but when executing the same code a second time it would add the new total to itself (causing the doubling effect).

comment:3 Changed 12 months ago by Nicklas Nordborg

Milestone: Reggie v4.24Reggie v4.23.1

comment:4 Changed 12 months ago by Nicklas Nordborg

In 5621:

References #1181: Incorrect counter for pilot reports in the activity log

Add a check to the "merge" actions so that an entry cannot be merged with itself.

Note: See TracTickets for help on using tickets.