Opened 3 years ago

Closed 3 years ago

#1049 closed enhancement (fixed)

Improvments to the FrozenTissueDate wizards

Reported by: Nicklas Nordborg Owned by: Nicklas Nordborg
Priority: major Milestone: Reggie v4.18
Component: net.sf.basedb.reggie Keywords:
Cc:

Description

See #969 for current implementation.

  • Duplicates should no longer be reported. It is not an error or problem that needs to be investigated. In most cases it simply means that there are exists two samples.
  • PAD values are sometimes entered with a space between the prefix and the ID. Spaces should be removed before looking for a match in our database.
  • Warnings should be registered in a 'blacklist' file with line number and ID. The next time the wizard is used blacklisted entries should be ignored (this could be an option that is enabled by default). Only new warnings will be displayed (and added to the blacklist). It might also be useful to register the "comment" column in the blacklist if it needs to investigated later.

Change History (6)

comment:1 Changed 3 years ago by Nicklas Nordborg

Milestone: Reggie v4.17Reggie v4.18

Ticket retargeted after milestone closed

comment:2 Changed 3 years ago by Nicklas Nordborg

Status: newassigned

comment:3 Changed 3 years ago by Nicklas Nordborg

(In [4804]) References #1049: Improvments to the FrozenTissueDate? wizards

Warnings are no longer generated for duplicate entries. We still need to keep track if it internally, since the annotation batcher will throw an exception if we try to process the same item more than one time.

comment:4 Changed 3 years ago by Nicklas Nordborg

(In [4805]) References #1049: Improvments to the FrozenTissueDate? wizards

Added support for finding PAD values even if they contains a space in the file.

The query now contains an OR condition like:

PAD = <pad> OR PAD = <pad with no spaces>

comment:5 Changed 3 years ago by Nicklas Nordborg

(In [4806]) References #1049: Improvments to the FrozenTissueDate? wizards

The importer now creates a file /home/SCANB/FrozenTissueFiles/last-import-warnings.csv where all warnings from the previous import are saved. If the file doesn't exists it will be created.

The next time the wizard is used it will still run as normal, but each warning is compared to what is found in the last-import-warnings.csv. To be considered equal, the line number and ProvId value must be the same.

The report will only display the new warnings to begin with. If there are old warnings, there will be an option to display them as well.

comment:6 Changed 3 years ago by Nicklas Nordborg

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.